wip: Fix the monitoring test #3228
Conversation
kubevirt-bot
added
release-note-none
The "KubeVirtCRModified alert should fired when there is a modification on a CR" functional test became flacky. The test changes the KubeVirt CI, and then checks several metrics and alert. When checking the "kubevirt_hyperconverged_operator_health_status" alert, the test sometimes fails, as KubeVirt get into non stable state for a short while for every chenage in the KubeVirt CR, making the health alret to be in "critical" status, instead of "warning". This PR fixes the issue by modifiying the CDI CR instead of the KubeVirt CR, to get the same effect. Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
nunnatsa
force-pushed
the
fix-monitoring-functest
branch
from
c6c35a8 to
06749c2
Compare
Pull Request Test Coverage Report for Build 12455072728Details
💛 - Coveralls |
|
/lgtm |
|
hco-e2e-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
nunnatsa
force-pushed
the
fix-monitoring-functest
branch
from
af1dc33 to
8356578
Compare
|
|
hco-e2e-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-operator-sdk-azure, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hco-e2e-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@nunnatsa: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kubevirt-bot
added
the
do-not-merge/work-in-progress
What this PR does / why we need it:
The "KubeVirtCRModified alert should fired when there is a modification on a CR" functional test became flacky.
The test changes the KubeVirt CR, and then checks several metrics and alerts. When checking the "kubevirt_hyperconverged_operator_health_status" alert, the test sometimes fails, as KubeVirt get into non stable state for a short while for every chenage in the KubeVirt CR, making the health alret to be in "critical" status, instead of "warning".
This PR fixes the issue by modifiying the CDI CR instead of the KubeVirt CR, to get the same effect.
Jira Ticket:
Release note: