dataImportCronTemplates: Remove CentOS 7 & stream 8

[lyarwood]

What this PR does / why we need it:

Both releases are now EOL with their associated containerdisks also deprecated ahead of removal in the near future:

kubevirt/containerdisks#154
kubevirt/containerdisks#152

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

• PR Message
• Commit Messages
• How to test
• Unit Tests
• Functional Tests
• User Documentation
• Developer Documentation
• Upgrade Scenario
• Uninstallation Scenario
• Backward Compatibility
• Troubleshooting Friendly

Jira Ticket:

https://issues.redhat.com/browse/CNV-43911

Release note:

CentOS 7 & CentOS stream 8 are now EOL so the associated `DataImportCronTemplates` have been removed

[coveralls]

Pull Request Test Coverage Report for Build 10509285962

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 85.756%

---

Totals
Change from base Build 10509043708:	0.0%
Covered Lines:	5304
Relevant Lines:	6185

---

💛 - Coveralls

[lyarwood]

/retest-required

[nunnatsa]

Thanks for the PR @lyarwood

Please also fix

hyperconverged-cluster-operator/tests/func-tests/golden_image_test.go

Line 35 in ee5ba66

expectedImages = []string{"centos-7-image-cron", "centos-stream8-image-cron", "centos-stream9-image-cron", "centos8-image-cron-is", "fedora-image-cron"}

[lyarwood]

/hold

[nunnatsa]

@lyarwood Another change needed in the functional test - sorry for missing that.

Please also update the expectedImageStreams variable in

hyperconverged-cluster-operator/tests/func-tests/golden_image_test.go

Lines 37 to 43 in ee5ba66

	expectedImageStreams = []tests.ImageStreamConfig{
	{
	Name: "centos8",
	RegistryName: "quay.io/kubevirt/centos8-container-disk-images",
	UsageImages: []string{"centos8-image-cron-is"},
	},
	}

[lyarwood]

@lyarwood Another change needed in the functional test - sorry for missing that.

Please also update the expectedImageStreams variable in

hyperconverged-cluster-operator/tests/func-tests/golden_image_test.go

Lines 37 to 43 in ee5ba66

	expectedImageStreams = []tests.ImageStreamConfig{
	{
	Name: "centos8",
	RegistryName: "quay.io/kubevirt/centos8-container-disk-images",
	UsageImages: []string{"centos8-image-cron-is"},
	},
	}

Yup sorry didn't have time to fix this up yet thus the hold, will find time today.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[lyarwood]

/hold cancel

Should be fixed now, I had just mistakenly used the image stream name in UsageImages instead of the DataImportCron name.

[hco-bot]

hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure
hco-e2e-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-azure

[kubevirt-bot]

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

In response to this:

hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure
hco-e2e-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hco-bot]

hco-e2e-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-azure
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure
hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

[kubevirt-bot]

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

In response to this:

hco-e2e-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-azure
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure
hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hco-bot]

hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded.
/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

[kubevirt-bot]

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

In response to this:

hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded.
/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[nunnatsa]

/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@lyarwood: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure	8e909d4	link	false	/test hco-e2e-upgrade-prev-operator-sdk-sno-azure
ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure	8e909d4	link	false	/test hco-e2e-upgrade-operator-sdk-sno-azure
ci/prow/hco-e2e-operator-sdk-sno-azure	8e909d4	link	false	/test hco-e2e-operator-sdk-sno-azure
ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure	8e909d4	link	true	/test hco-e2e-consecutive-operator-sdk-upgrades-azure
ci/prow/hco-e2e-kv-smoke-azure	8e909d4	link	true	/test hco-e2e-kv-smoke-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[hco-bot]

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

[kubevirt-bot]

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[0xFelix]

/cherry-pick release-1.12
/cherry-pick release-1.11
/cherry-pick release-1.10
/cherry-pick release-1.9

[0xFelix]

/cherry-pick release-1.8

[kubevirt-bot]

@0xFelix: #3048 failed to apply on top of branch "release-1.12":

Applying: dataImportCronTemplates: Remove CentOS 7 & stream 8
Using index info to reconstruct a base tree...
M	assets/dataImportCronTemplates/dataImportCronTemplates.yaml
M	tests/func-tests/golden_image_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/func-tests/golden_image_test.go
CONFLICT (content): Merge conflict in tests/func-tests/golden_image_test.go
Auto-merging assets/dataImportCronTemplates/dataImportCronTemplates.yaml
CONFLICT (content): Merge conflict in assets/dataImportCronTemplates/dataImportCronTemplates.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 dataImportCronTemplates: Remove CentOS 7 & stream 8
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.12
/cherry-pick release-1.11
/cherry-pick release-1.10
/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kubevirt-bot]

@0xFelix: #3048 failed to apply on top of branch "release-1.8":

Applying: dataImportCronTemplates: Remove CentOS 7 & stream 8
Using index info to reconstruct a base tree...
A	tests/func-tests/golden_image_test.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): tests/func-tests/golden_image_test.go deleted in HEAD and modified in dataImportCronTemplates: Remove CentOS 7 & stream 8. Version dataImportCronTemplates: Remove CentOS 7 & stream 8 of tests/func-tests/golden_image_test.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 dataImportCronTemplates: Remove CentOS 7 & stream 8
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.