Skip to content

Commit

Permalink
chore: Bump golangci-lint
Browse files Browse the repository at this point in the history
... and update its configuration and fix an issue found by the new
version.

Signed-off-by: Felix Matouschek <[email protected]>
  • Loading branch information
0xFelix committed Mar 25, 2024
1 parent fb52f47 commit 4c417b1
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ linters-settings:
# don't include the "operation" and "assign"
checks: argument,case,condition,return
govet:
check-shadowing: true
shadow: true
lll:
line-length: 140
maligned:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ vendor:
go mod vendor

GOLANGCI_LINT ?= $(LOCALBIN)/golangci-lint
GOLANGCI_LINT_VERSION ?= v1.55.2
GOLANGCI_LINT_VERSION ?= v1.57.1

.PHONY: lint
lint:
Expand Down
2 changes: 1 addition & 1 deletion cmd/medius/images/verify.go
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ func randName(name string) string {
}

func waitVMReady(ctx context.Context, name string, client kvirtcli.VirtualMachineInterface, timeout int) error {
return wait.PollImmediateWithContext(ctx, time.Second, time.Duration(timeout)*time.Second, func(_ context.Context) (bool, error) {
return wait.PollUntilContextTimeout(ctx, time.Second, time.Duration(timeout)*time.Second, true, func(_ context.Context) (bool, error) {
vm, err := client.Get(ctx, name, &metav1.GetOptions{})

if err != nil {
Expand Down

0 comments on commit 4c417b1

Please sign in to comment.