Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update osinfo-db #652

Conversation

nestoracunablanco
Copy link
Contributor

What this PR does / why we need it: s390x enablement

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

Signed-off-by: Nestor Acuna Blanco <[email protected]>
@kubevirt-bot kubevirt-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 2, 2024
@kubevirt-bot kubevirt-bot requested a review from 0xFelix December 2, 2024 07:23
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 2, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign akrejcir for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Dec 2, 2024

@nestoracunablanco: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-common-templates-windows2016 f41c4e5 link true /test e2e-gcp-common-templates-windows2016
ci/prow/e2e-gcp-common-templates-windows10 f41c4e5 link true /test e2e-gcp-common-templates-windows10
ci/prow/e2e-gcp-common-templates-rhel7 f41c4e5 link true /test e2e-gcp-common-templates-rhel7
ci/prow/e2e-gcp-common-templates-unit-tests f41c4e5 link true /test e2e-gcp-common-templates-unit-tests
ci/prow/e2e-gcp-common-templates-windows2019 f41c4e5 link true /test e2e-gcp-common-templates-windows2019

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ksimon1
Copy link
Member

ksimon1 commented Dec 2, 2024

We have automation in place, which bumps the osinfo module every Monday :) #653

@nestoracunablanco
Copy link
Contributor Author

Thank you! I will drop this pull request and check if the other one passes the CI checks.

@nestoracunablanco nestoracunablanco deleted the feat/updateOsInfoDb branch December 2, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants