Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: creation of /.ansible folder in builder dockerfile #648

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Nov 26, 2024

What this PR does / why we need it:
fix: creation of /.ansible folder in builder dockerfile

the automation for releases stopped working because of error with folder permission (https://github.com/kubevirt/common-templates/actions/runs/12034572916).
By changing the command to RUN mkdir -m 777 -p /.ansible/tmp the release automation started working (https://github.com/ksimon1/common-templates/actions/runs/12037461414/job/33560963925#step:4:1092).

Release note:

NONE

the automation for releases stopped working because of error
with folder permission.
By changing the command to RUN mkdir -m 777 -p /.ansible/tmp
the release automation started working.

Signed-off-by: Karel Simon <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 26, 2024
@fossedihelm
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
@fossedihelm
Copy link
Contributor

/retest

@fossedihelm
Copy link
Contributor

@0xFelix PTAL

Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/retest

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2024
@ksimon1
Copy link
Member Author

ksimon1 commented Nov 27, 2024

/retest

@kubevirt-bot kubevirt-bot merged commit bfb8413 into kubevirt:master Nov 27, 2024
19 checks passed
@ksimon1
Copy link
Member Author

ksimon1 commented Nov 27, 2024

/cherrypick release-v0.29

@kubevirt-bot
Copy link
Contributor

@ksimon1: new pull request created: #650

In response to this:

/cherrypick release-v0.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fossedihelm
Copy link
Contributor

/cherrypick release-v0.27

@kubevirt-bot
Copy link
Contributor

@fossedihelm: new pull request created: #651

In response to this:

/cherrypick release-v0.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants