Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: s390x centos-stream9 enablement #645

Merged

Conversation

nestoracunablanco
Copy link
Contributor

What this PR does / why we need it: s390x enablement

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

Signed-off-by: Nestor Acuna Blanco <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 25, 2024
@nestoracunablanco
Copy link
Contributor Author

/retest

@ksimon1
Copy link
Member

ksimon1 commented Nov 26, 2024

/approve
@fossedihelm can you please review this PR?

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@fossedihelm
Copy link
Contributor

/lgtm
just a note: containerdisk for s390x is not available

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
@nestoracunablanco
Copy link
Contributor Author

nestoracunablanco commented Nov 26, 2024

Thanks @fossedihelm @ksimon1!
FYI: centos-stream 9 containerdisk is available for s390x. Link here.

@fossedihelm
Copy link
Contributor

Thanks @fossedihelm @ksimon1! FYI: centos-stream 9 containerdisk is available for s390x. Link here.

In osinfo-db/data/os/centos.org/centos-stream-9.xml I only see x86_64

    <image arch="x86_64" format="containerdisk" cloud-init="true">
      <url>docker://quay.io/containerdisks/centos-stream:9</url>
    </image>
    <image arch="aarch64" format="qcow2" cloud-init="true">
      <url>https://cloud.centos.org/centos/9-stream/aarch64/images/CentOS-Stream-GenericCloud-9-latest.aarch64.qcow2</url>
    </image>
    <image arch="ppc64le" format="qcow2" cloud-init="true">
      <url>https://cloud.centos.org/centos/9-stream/ppc64le/images/CentOS-Stream-GenericCloud-9-latest.ppc64le.qcow2</url>
    </image>
    <image arch="s390x" format="qcow2" cloud-init="true">
      <url>https://cloud.centos.org/centos/9-stream/s390x/images/CentOS-Stream-GenericCloud-9-latest.s390x.qcow2</url>
    </image>
    <image arch="x86_64" format="qcow2" cloud-init="true">
      <url>https://cloud.centos.org/centos/9-stream/x86_64/images/CentOS-Stream-GenericCloud-9-latest.x86_64.qcow2</url>
    </image>

@kubevirt-bot kubevirt-bot merged commit 70820f3 into kubevirt:master Nov 26, 2024
19 checks passed
@0xFelix
Copy link
Member

0xFelix commented Nov 26, 2024

@fossedihelm Good catch, we totally missed that. This needs to be updated for a bunch of distributions (Fedora, CentOS, Ubuntu, ...).

@nestoracunablanco nestoracunablanco deleted the feat/centosStreams390x branch November 26, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants