Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: target archictecture as a parameter #642

Conversation

nestoracunablanco
Copy link
Contributor

The default value is x86_64, but it can be overridden. This change ensures compatibility with older versions.

What this PR does / why we need it: s390x enablement

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

The default value is x86_64, but it can be overridden. This change
ensures compatibility with older versions.

Signed-off-by: Nestor Acuna Blanco <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 22, 2024
@nestoracunablanco
Copy link
Contributor Author

/retest

@jcanocan
Copy link

Thanks!
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2024
@ksimon1
Copy link
Member

ksimon1 commented Nov 22, 2024

@fossedihelm can you please check this PR?

Copy link
Contributor

@fossedihelm fossedihelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good

@ksimon1
Copy link
Member

ksimon1 commented Nov 22, 2024

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2024
@kubevirt-bot kubevirt-bot merged commit a9fc5b0 into kubevirt:master Nov 22, 2024
18 checks passed
@nestoracunablanco nestoracunablanco deleted the feat/targetArchMakefileParameter branch November 22, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants