Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.27] Windows 11: enable TPM and EFI persistence #640

Merged
merged 3 commits into from
Dec 2, 2024
Merged

[release-v0.27] Windows 11: enable TPM and EFI persistence #640

merged 3 commits into from
Dec 2, 2024

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #611

/assign fossedihelm

Windows 11 now defaults to persistent TPM and EFI. This requires a storage class capable of ReadWriteMany Filesystem

@jean-edouard
Windows 11: enable TPM and EFI persistence
da89b4d 
The Windows 11 template enables TPM and EFI, since both a required.
However, they were both non-persistent by default, which means bitlocker won't work.
Also, in recent versions of Windows 11, bitlocker requires both TPM and EFI to be persistent.
This enables persistent EFI and TPM, which requires a RWO FS storage class to be present.

Signed-off-by: Jed Lejosne <[email protected]>
@jean-edouard
Windows 2k22: enable TPM and EFI persistence
31aba14 
Signed-off-by: Jed Lejosne <[email protected]>
@jean-edouard
test.sh: add VMPersistentState feature gate
5a42b02 
Signed-off-by: Jed Lejosne <[email protected]>
@kubevirt-bot kubevirt-bot mentioned this pull request Nov 20, 2024
Merged
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 20, 2024
@ksimon1
Copy link
Member

ksimon1 commented Nov 22, 2024

/retest

0xFelix
0xFelix reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@fossedihelm
Copy link
Contributor

/retest

@jcanocan
Copy link

/retest-required

@ksimon1
Copy link
Member

ksimon1 commented Nov 26, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
@fossedihelm
Copy link
Contributor

/retest

1 similar comment
@fossedihelm
Copy link
Contributor

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 28, 2024

@kubevirt-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-common-templates-windows2019 5a42b02 link true /test e2e-gcp-common-templates-windows2019
ci/prow/e2e-gcp-common-templates-windows2016 5a42b02 link true /test e2e-gcp-common-templates-windows2016
ci/prow/e2e-gcp-common-templates-windows10 5a42b02 link true /test e2e-gcp-common-templates-windows10

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ksimon1
Copy link
Member

ksimon1 commented Dec 2, 2024

I am merging this PR, because the failures are not related to this PR
/override e2e-gcp-common-templates-windows10
/override e2e-gcp-common-templates-windows2016
/override e2e-gcp-common-templates-windows2019

@kubevirt-bot
Copy link
Contributor Author

@ksimon1: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-gcp-common-templates-windows10
  • e2e-gcp-common-templates-windows2016
  • e2e-gcp-common-templates-windows2019

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-gcp-common-templates-centos-stream8
  • ci/prow/e2e-gcp-common-templates-centos-stream9
  • ci/prow/e2e-gcp-common-templates-centos6
  • ci/prow/e2e-gcp-common-templates-centos7
  • ci/prow/e2e-gcp-common-templates-fedora
  • ci/prow/e2e-gcp-common-templates-opensuse
  • ci/prow/e2e-gcp-common-templates-rhel7
  • ci/prow/e2e-gcp-common-templates-rhel8
  • ci/prow/e2e-gcp-common-templates-rhel9
  • ci/prow/e2e-gcp-common-templates-ubuntu
  • ci/prow/e2e-gcp-common-templates-unit-tests
  • ci/prow/e2e-gcp-common-templates-windows10
  • ci/prow/e2e-gcp-common-templates-windows11
  • ci/prow/e2e-gcp-common-templates-windows2016
  • ci/prow/e2e-gcp-common-templates-windows2019
  • ci/prow/e2e-gcp-common-templates-windows2022
  • ci/prow/e2e-gcp-go-tests
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

I am merging this PR, because the failures are not related to this PR
/override e2e-gcp-common-templates-windows10
/override e2e-gcp-common-templates-windows2016
/override e2e-gcp-common-templates-windows2019

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ksimon1
Copy link
Member

ksimon1 commented Dec 2, 2024

/override ci/prow/e2e-gcp-common-templates-windows10
/override ci/prow/e2e-gcp-common-templates-windows2016
/override ci/prow/e2e-gcp-common-templates-windows2019

@kubevirt-bot
Copy link
Contributor Author

@ksimon1: Overrode contexts on behalf of ksimon1: ci/prow/e2e-gcp-common-templates-windows10, ci/prow/e2e-gcp-common-templates-windows2016, ci/prow/e2e-gcp-common-templates-windows2019

In response to this:

/override ci/prow/e2e-gcp-common-templates-windows10
/override ci/prow/e2e-gcp-common-templates-windows2016
/override ci/prow/e2e-gcp-common-templates-windows2019

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot merged commit acc00fa into kubevirt:release-v0.27 Dec 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix left review comments

@geetikakay geetikakay Awaiting requested review from geetikakay

@jcanocan jcanocan Awaiting requested review from jcanocan

Assignees

@fossedihelm fossedihelm

@ksimon1 ksimon1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kubevirt-bot @ksimon1 @fossedihelm @jcanocan @0xFelix @jean-edouard