Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update legacy containerdisks url #638

Merged

Conversation

nestoracunablanco
Copy link
Contributor

The only image that remains in legacy status is CentOS 6. The link https://quay.io/repository/containerdisks/centos?tab=tags currently contains only CentOS 7 and CentOS 8 images.

What this PR does / why we need it: s390x enablement

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 20, 2024
@nestoracunablanco
Copy link
Contributor Author

Hi @0xFelix, @ksimon1, @jcanocan, and @akrejcir. I currently have 9 commits in the pipeline. Would you prefer that I streamline them into a single pull request, or deliver them in smaller chunks?

The only image that remains in legacy status is CentOS 6. The link
https://quay.io/repository/containerdisks/centos?tab=tags currently
contains only CentOS 7 and CentOS 8 images.

Signed-off-by: Nestor Acuna Blanco <[email protected]>
@nestoracunablanco
Copy link
Contributor Author

/retest

2 similar comments
@nestoracunablanco
Copy link
Contributor Author

/retest

@nestoracunablanco
Copy link
Contributor Author

/retest

@ksimon1
Copy link
Member

ksimon1 commented Nov 21, 2024

@nestoracunablanco please deliver them in smaller chunks 👍

@ksimon1
Copy link
Member

ksimon1 commented Nov 21, 2024

@fossedihelm can you please review this PR?
/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
@fossedihelm
Copy link
Contributor

Thank you!
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2024
@kubevirt-bot kubevirt-bot merged commit d891490 into kubevirt:master Nov 22, 2024
18 checks passed
@nestoracunablanco nestoracunablanco deleted the fix/legacyContainerDisks branch November 22, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants