-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multiarch fedora template. #624
feat: multiarch fedora template. #624
Conversation
Fedora offers images for a variety of architectures, which can be included as a template parameter. Within the template, there is a specific parameter for defining the architecture. For the sake of simplicity, I have currently set the host architecture. Signed-off-by: Nestor Acuna Blanco <[email protected]>
Hi @nestoracunablanco. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@ksimon1 Can you remind me why we need this field at all in the template? @nestoracunablanco Did you check all fields enabled in the template work with s390x? |
@0xFelix, next Monday, I will likely have access to a machine capable of running (internally) the Fedora end-to-end tests on s390x. So far, I have verified that the generated template includes the link to the s390x images and correctly points to the s390x architecture (when running it on s390x). Additionally, I tested to ensure that it keeps the functionality running on amd64, which you will probably notice in the CI. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ksimon1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Fedora offers images for a variety of architectures, which can be included as a template parameter. Within the template, there is a specific parameter for defining the architecture.
For the sake of simplicity, I have currently set the host architecture.
What this PR does / why we need it: s390x enablement
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: