Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiarch fedora template. #624

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

nestoracunablanco
Copy link
Contributor

Fedora offers images for a variety of architectures, which can be included as a template parameter. Within the template, there is a specific parameter for defining the architecture.

For the sake of simplicity, I have currently set the host architecture.

What this PR does / why we need it: s390x enablement

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

Fedora offers images for a variety of architectures, which can be
included as a template parameter. Within the template, there is a
specific parameter for defining the architecture.

For the sake of simplicity, I have currently set the host architecture.

Signed-off-by: Nestor Acuna Blanco <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 17, 2024
Copy link

openshift-ci bot commented Oct 17, 2024

Hi @nestoracunablanco. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 17, 2024
@jcanocan
Copy link

/ok-to-test
/cc @ksimon1

@kubevirt-bot kubevirt-bot requested a review from ksimon1 October 17, 2024 12:52
@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2024
@0xFelix
Copy link
Member

0xFelix commented Oct 17, 2024

@ksimon1 Can you remind me why we need this field at all in the template?

@nestoracunablanco Did you check all fields enabled in the template work with s390x?

@nestoracunablanco
Copy link
Contributor Author

nestoracunablanco commented Oct 17, 2024

@0xFelix, next Monday, I will likely have access to a machine capable of running (internally) the Fedora end-to-end tests on s390x. So far, I have verified that the generated template includes the link to the s390x images and correctly points to the s390x architecture (when running it on s390x). Additionally, I tested to ensure that it keeps the functionality running on amd64, which you will probably notice in the CI.

@ksimon1
Copy link
Member

ksimon1 commented Oct 17, 2024

@ksimon1 Can you remind me why we need this field at all in the template?

#573
As @lyarwood described in PR, the templates are only tested against amd64 machines

@ksimon1
Copy link
Member

ksimon1 commented Oct 25, 2024

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2024
@jcanocan
Copy link

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2024
@kubevirt-bot kubevirt-bot merged commit 476bd83 into kubevirt:master Oct 25, 2024
17 of 18 checks passed
@nestoracunablanco nestoracunablanco deleted the feat/fedoras390x branch October 25, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants