Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable virtctl download based on host architecture #608

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

nestoracunablanco
Copy link
Contributor

What this PR does / why we need it: s390x enablement

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:


@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 9, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ksimon1 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 9, 2024
Copy link

openshift-ci bot commented Sep 9, 2024

Hi @nestoracunablanco. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@0xFelix
Copy link
Member

0xFelix commented Sep 9, 2024

/test all

@kubevirt-bot
Copy link
Contributor

@0xFelix: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@0xFelix
Copy link
Member

0xFelix commented Sep 9, 2024

/retest-required

@nestoracunablanco
Copy link
Contributor Author

/test e2e-gcp-common-templates-centos7

@kubevirt-bot
Copy link
Contributor

@nestoracunablanco: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test e2e-gcp-common-templates-centos7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

1 similar comment
Copy link

openshift-ci bot commented Sep 10, 2024

@nestoracunablanco: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test e2e-gcp-common-templates-centos7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nestoracunablanco
Copy link
Contributor Author

Hi @0xFelix, it appears that the first test is experiencing a timeout issue. If you give me the "ok-to-test", I can run the tests one by one and keep you updated when everything is green.

@0xFelix
Copy link
Member

0xFelix commented Sep 10, 2024

/ok-to-test
/retest

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 10, 2024
@nestoracunablanco
Copy link
Contributor Author

@0xFelix, are you experiencing issues with the CI in other branches or repositories?

@0xFelix
Copy link
Member

0xFelix commented Sep 10, 2024

@nestoracunablanco Looks like the CI resources are exhausted, we need to wait.

@nestoracunablanco
Copy link
Contributor Author

/retest

1 similar comment
@nestoracunablanco
Copy link
Contributor Author

/retest

@nestoracunablanco
Copy link
Contributor Author

/test e2e-gcp-common-templates-rhel8

@kubevirt-bot
Copy link
Contributor

@nestoracunablanco: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-rhel8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nestoracunablanco
Copy link
Contributor Author

/retest e2e-gcp-common-templates-rhel8

@kubevirt-bot
Copy link
Contributor

@nestoracunablanco: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/retest e2e-gcp-common-templates-rhel8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Sep 11, 2024

@nestoracunablanco: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-gcp-common-templates-centos-stream8
  • /test e2e-gcp-common-templates-centos-stream9
  • /test e2e-gcp-common-templates-centos6
  • /test e2e-gcp-common-templates-centos7
  • /test e2e-gcp-common-templates-fedora
  • /test e2e-gcp-common-templates-opensuse
  • /test e2e-gcp-common-templates-rhel7
  • /test e2e-gcp-common-templates-rhel8
  • /test e2e-gcp-common-templates-rhel9
  • /test e2e-gcp-common-templates-ubuntu
  • /test e2e-gcp-common-templates-unit-tests
  • /test e2e-gcp-common-templates-windows10
  • /test e2e-gcp-common-templates-windows11
  • /test e2e-gcp-common-templates-windows2016
  • /test e2e-gcp-common-templates-windows2019
  • /test e2e-gcp-common-templates-windows2022
  • /test e2e-gcp-go-tests

Use /test all to run all jobs.

In response to this:

/retest e2e-gcp-common-templates-rhel8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Sep 11, 2024

@nestoracunablanco: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-common-templates-centos-stream9 5fb2be7 link true /test e2e-gcp-common-templates-centos-stream9
ci/prow/e2e-gcp-common-templates-centos7 5fb2be7 link true /test e2e-gcp-common-templates-centos7
ci/prow/e2e-gcp-common-templates-rhel7 5fb2be7 link true /test e2e-gcp-common-templates-rhel7
ci/prow/e2e-gcp-common-templates-centos-stream8 5fb2be7 link true /test e2e-gcp-common-templates-centos-stream8
ci/prow/e2e-gcp-common-templates-rhel9 5fb2be7 link true /test e2e-gcp-common-templates-rhel9
ci/prow/e2e-gcp-common-templates-windows10 5fb2be7 link true /test e2e-gcp-common-templates-windows10
ci/prow/e2e-gcp-common-templates-windows2022 5fb2be7 link true /test e2e-gcp-common-templates-windows2022
ci/prow/e2e-gcp-common-templates-windows11 5fb2be7 link true /test e2e-gcp-common-templates-windows11
ci/prow/e2e-gcp-common-templates-windows2019 5fb2be7 link true /test e2e-gcp-common-templates-windows2019
ci/prow/e2e-gcp-common-templates-windows2016 5fb2be7 link true /test e2e-gcp-common-templates-windows2016
ci/prow/e2e-gcp-common-templates-rhel8 5fb2be7 link true /test e2e-gcp-common-templates-rhel8

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ksimon1
Copy link
Member

ksimon1 commented Sep 11, 2024

we are experiencing issues with CDI in e2e tests.
This PR is not causing the issues anf thus I am merging it.

@ksimon1 ksimon1 merged commit 2b010e9 into kubevirt:master Sep 11, 2024
8 of 20 checks passed
@nestoracunablanco nestoracunablanco deleted the feat/virctlMultiarch branch September 12, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants