Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

centos-7,centos-stream8: Mark as deprecated with recent EOLs #598

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

0xFelix
Copy link
Member

@0xFelix 0xFelix commented Aug 1, 2024

What this PR does / why we need it:

Mark CentOS 7 and Stream 8 as deprecated with recent EOLs

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

CentOS 7 and Stream 8 templates are now deprecated

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 1, 2024
@0xFelix
Copy link
Member Author

0xFelix commented Aug 1, 2024

/cherry-pick release-v0.29

@kubevirt-bot
Copy link
Contributor

@0xFelix: once the present PR merges, I will cherry-pick it on top of release-v0.29 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dominikholler
Copy link
Collaborator

FYI @acardace @metalice

@ksimon1
Copy link
Member

ksimon1 commented Aug 1, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2024
@ksimon1
Copy link
Member

ksimon1 commented Aug 1, 2024

/retest

@ksimon1
Copy link
Member

ksimon1 commented Aug 1, 2024

/approve
@0xFelix do we want to keep the testing automation for these templates in place?

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2024
@0xFelix
Copy link
Member Author

0xFelix commented Aug 1, 2024

We can drop the automation once we remove the templates.

@kubevirt-bot kubevirt-bot merged commit 3efbaa8 into kubevirt:master Aug 1, 2024
19 of 20 checks passed
@kubevirt-bot
Copy link
Contributor

@0xFelix: new pull request created: #599

In response to this:

/cherry-pick release-v0.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants