Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add pip to builder/Dockerfile #596

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

nestoracunablanco
Copy link
Contributor

To ensure early failure in the unit tests, it is necessary to verify the installation of the Python OpenShift package. One effective way to accomplish this is by using the pip show command. Therefore, we need to enhance the Dockerfile to include pip.

What this PR does / why we need it: Fail early

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:


To ensure early failure in the unit tests, it is necessary to
verify the installation of the Python OpenShift package. One
effective way to accomplish this is by using the pip show command.
Therefore, we need to enhance the Dockerfile to include pip.

Signed-off-by: Nestor Acuna Blanco <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 31, 2024
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 31, 2024
Copy link

openshift-ci bot commented Jul 31, 2024

Hi @nestoracunablanco. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ksimon1
Copy link
Member

ksimon1 commented Jul 31, 2024

Hi @nestoracunablanco,
can you please elaborate why do you need to verify the installation of the Python OpenShift package?

@nestoracunablanco
Copy link
Contributor Author

Hi @ksimon1,
for context, please refer to this PR, which explains why we need to perform this verification.
The issue with the automation/unit-test.sh script is that it executes several oc commands to apply namespaces and templates, followed by the execution of python scripts. If the python scripts fail, the preceding oc commands are done unnecessary.
Implementing a verification step to check if the package is installed would provide a quick and low-cost early validation.

@ksimon1
Copy link
Member

ksimon1 commented Jul 31, 2024

@nestoracunablanco thanks for the explanation. Make sense to me 👍
/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2024
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2024
@ksimon1
Copy link
Member

ksimon1 commented Jul 31, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2024
@nestoracunablanco
Copy link
Contributor Author

/retest

@kubevirt-bot kubevirt-bot merged commit a91b675 into kubevirt:master Aug 1, 2024
20 checks passed
@nestoracunablanco nestoracunablanco deleted the fix/pipDockerfile branch August 1, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants