fix: e2e-tests preconditions in makefile

The preconditions for the end-to-end (e2e) tests were previously embedded within the script. This update ensures that unnecessary oc commands are not executed in the event of an error during the generation process. Signed-off-by: Nestor Acuna Blanco <[email protected]>
kubevirt · Aug 19, 2024 · 7b67a0f · 7b67a0f
1 parent d9e49da
commit 7b67a0f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/automation/test.sh b/automation/test.sh
@@ -127,10 +127,6 @@ then
     export CLUSTERENV=$ocenv
 fi
 
-git submodule update --init
-
-make generate
-
 #set terminationGracePeriodSeconds to 0
 for filename in dist/templates/*; do
     sed -i -e 's/^\(\s*terminationGracePeriodSeconds\s*:\s*\).*/\10/' $filename

diff --git a/makefile b/makefile
@@ -26,7 +26,7 @@ dist/common-templates.yaml: generate
 release: dist/common-templates.yaml
 	cp dist/common-templates.yaml dist/common-templates-$(VERSION).yaml
 
-e2e-tests:
+e2e-tests: update-osinfo-db generate
 	./automation/test.sh
 
 go-tests: