Skip to content

Commit

Permalink
Merge pull request #233 from kubevirt-bot/cherry-pick-219-to-release-1.1
Browse files Browse the repository at this point in the history
[release-1.1] Add preferences for RHEL 10 Beta and CentOS 10 Stream
  • Loading branch information
kubevirt-bot authored Aug 7, 2024
2 parents 4c01236 + 8d5bfb9 commit d1baa25
Show file tree
Hide file tree
Showing 24 changed files with 221 additions and 0 deletions.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,8 @@ Name | Guest OS
alpine | Alpine
centos.7 | CentOS 7
centos.7.desktop | CentOS 7
centos.stream10 | CentOS Stream 10
centos.stream10.desktop | CentOS Stream 10
centos.stream8 | CentOS Stream 8
centos.stream8.desktop | CentOS Stream 8
centos.stream8.dpdk | CentOS Stream 8
Expand All @@ -320,6 +322,8 @@ fedora | Fedora (amd64)
fedora.arm64 | Fedora (arm64)
opensuse.leap | OpenSUSE Leap
opensuse.tumbleweed | OpenSUSE Tumbleweed
rhel.10 | Red Hat Enterprise Linux 10 Beta (amd64)
rhel.10.arm64 | Red Hat Enterprise Linux 10 Beta (arm64)
rhel.7 | Red Hat Enterprise Linux 7
rhel.7.desktop | Red Hat Enterprise Linux 7
rhel.8 | Red Hat Enterprise Linux 8
Expand Down
14 changes: 14 additions & 0 deletions preferences/centos/10_stream/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
- ../base

components:
- ./metadata
- ./requirements
- ../../components/rng
- ../../components/disk-dedicatediothread

nameSuffix: ".stream10"
11 changes: 11 additions & 0 deletions preferences/centos/10_stream/metadata/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
apiVersion: kustomize.config.k8s.io/v1alpha1
kind: Component

patches:
- path: ./metadata.yaml
target:
kind: VirtualMachinePreference
- path: ./metadata.yaml
target:
kind: VirtualMachineClusterPreference
7 changes: 7 additions & 0 deletions preferences/centos/10_stream/metadata/metadata.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
apiVersion: instancetype.kubevirt.io/v1beta1
kind: VirtualMachinePreference
metadata:
name: metadata
annotations:
openshift.io/display-name: "CentOS Stream 10"
11 changes: 11 additions & 0 deletions preferences/centos/10_stream/requirements/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
apiVersion: kustomize.config.k8s.io/v1alpha1
kind: Component

patches:
- path: ./requirements.yaml
target:
kind: VirtualMachinePreference
- path: ./requirements.yaml
target:
kind: VirtualMachineClusterPreference
12 changes: 12 additions & 0 deletions preferences/centos/10_stream/requirements/requirements.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
apiVersion: instancetype.kubevirt.io/v1beta1
kind: VirtualMachinePreference
metadata:
name: requirements
spec:
# https://access.redhat.com/articles/rhel-limits#minimum-required-memory-3
requirements:
cpu:
guest: 1
memory:
guest: 1.5Gi
11 changes: 11 additions & 0 deletions preferences/centos/10_stream_desktop/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
- ../10_stream

components:
- ../../components/tablet-virtio

nameSuffix: ".desktop"
2 changes: 2 additions & 0 deletions preferences/centos/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
- ./10_stream_desktop
- ./10_stream
- ./9_stream_desktop
- ./9_stream_dpdk
- ./9_stream
Expand Down
9 changes: 9 additions & 0 deletions preferences/components/efi/efi.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
apiVersion: instancetype.kubevirt.io/v1beta1
kind: VirtualMachinePreference
metadata:
name: efi
spec:
firmware:
preferredUseEfi: true
preferredUseSecureBoot: false
11 changes: 11 additions & 0 deletions preferences/components/efi/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
apiVersion: kustomize.config.k8s.io/v1alpha1
kind: Component

patches:
- path: ./efi.yaml
target:
kind: VirtualMachinePreference
- path: ./efi.yaml
target:
kind: VirtualMachineClusterPreference
15 changes: 15 additions & 0 deletions preferences/rhel/10/amd64/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
- ../../base

components:
- ./metadata
- ./requirements
- ../../../components/disk-dedicatediothread
- ../../../components/efi
- ../../../components/rng

nameSuffix: ".10"
11 changes: 11 additions & 0 deletions preferences/rhel/10/amd64/metadata/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
apiVersion: kustomize.config.k8s.io/v1alpha1
kind: Component

patches:
- path: ./metadata.yaml
target:
kind: VirtualMachinePreference
- path: ./metadata.yaml
target:
kind: VirtualMachineClusterPreference
9 changes: 9 additions & 0 deletions preferences/rhel/10/amd64/metadata/metadata.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
apiVersion: instancetype.kubevirt.io/v1beta1
kind: VirtualMachinePreference
metadata:
name: metadata
annotations:
openshift.io/display-name: "Red Hat Enterprise Linux 10 Beta (amd64)"
labels:
instancetype.kubevirt.io/arch: "amd64"
11 changes: 11 additions & 0 deletions preferences/rhel/10/amd64/requirements/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
apiVersion: kustomize.config.k8s.io/v1alpha1
kind: Component

patches:
- path: ./requirements.yaml
target:
kind: VirtualMachinePreference
- path: ./requirements.yaml
target:
kind: VirtualMachineClusterPreference
12 changes: 12 additions & 0 deletions preferences/rhel/10/amd64/requirements/requirements.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
apiVersion: instancetype.kubevirt.io/v1beta1
kind: VirtualMachinePreference
metadata:
name: requirements
spec:
# https://access.redhat.com/articles/rhel-limits#minimum-required-memory-3
requirements:
cpu:
guest: 1
memory:
guest: 1.5Gi
14 changes: 14 additions & 0 deletions preferences/rhel/10/arm64/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
- ../../base

components:
- ./metadata
- ./requirements
- ../../../components/disk-dedicatediothread
- ../../../components/rng

nameSuffix: ".10.arm64"
11 changes: 11 additions & 0 deletions preferences/rhel/10/arm64/metadata/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
apiVersion: kustomize.config.k8s.io/v1alpha1
kind: Component

patches:
- path: ./metadata.yaml
target:
kind: VirtualMachinePreference
- path: ./metadata.yaml
target:
kind: VirtualMachineClusterPreference
9 changes: 9 additions & 0 deletions preferences/rhel/10/arm64/metadata/metadata.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
apiVersion: instancetype.kubevirt.io/v1beta1
kind: VirtualMachinePreference
metadata:
name: metadata
annotations:
openshift.io/display-name: "Red Hat Enterprise Linux 10 Beta (arm64)"
labels:
instancetype.kubevirt.io/arch: "arm64"
11 changes: 11 additions & 0 deletions preferences/rhel/10/arm64/requirements/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
apiVersion: kustomize.config.k8s.io/v1alpha1
kind: Component

patches:
- path: ./requirements.yaml
target:
kind: VirtualMachinePreference
- path: ./requirements.yaml
target:
kind: VirtualMachineClusterPreference
12 changes: 12 additions & 0 deletions preferences/rhel/10/arm64/requirements/requirements.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
apiVersion: instancetype.kubevirt.io/v1beta1
kind: VirtualMachinePreference
metadata:
name: requirements
spec:
# https://access.redhat.com/articles/rhel-limits#minimum-required-memory-3
requirements:
cpu:
guest: 1
memory:
guest: 1.5Gi
7 changes: 7 additions & 0 deletions preferences/rhel/10/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
- ./arm64
- ./amd64
1 change: 1 addition & 0 deletions preferences/rhel/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
- ./10
- ./9_realtime
- ./9_desktop
- ./9_dpdk
Expand Down
2 changes: 2 additions & 0 deletions tests/functests/instancetype_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ var _ = Describe("Common instance types func tests", func() {
[]testFn{expectGuestAgentToBeConnected, expectSSHToRunCommandOnLinux("cloud-user")}),
Entry("[test_id:TODO] RHEL 9", rhel9ContainerDisk, map[string]string{"amd64": "rhel.9", "arm64": "rhel.9.arm64"},
[]testFn{expectGuestAgentToBeConnected, expectSSHToRunCommandOnLinux("cloud-user")}),
Entry("[test_id:TODO] RHEL 10", rhel10ContainerDisk, map[string]string{"amd64": "rhel.10", "arm64": "rhel.10.arm64"},
[]testFn{expectGuestAgentToBeConnected, expectSSHToRunCommandOnLinux("cloud-user")}),
Entry("[test_id:10741] Ubuntu 18.04", ubuntu1804ContainerDisk, map[string]string{"amd64": "ubuntu"},
[]testFn{expectSSHToRunCommandOnLinux("ubuntu")}),
Entry("[test_id:10742] Ubuntu 20.04", ubuntu2004ContainerDisk, map[string]string{"amd64": "ubuntu", "arm64": "ubuntu"},
Expand Down
4 changes: 4 additions & 0 deletions tests/functests/test_suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ const (
defaultCentosStream8ContainerDisk = "quay.io/containerdisks/centos-stream:8"
defaultCentosStream9ContainerDisk = "quay.io/containerdisks/centos-stream:9"
defaultRHEL9ContainerDisk = "registry:5000/rhel-guest-image:9"
defaultRHEL10ContainerDisk = "registry:5000/rhel-guest-image:10"
defaultUbuntu1804ContainerDisk = "quay.io/containerdisks/ubuntu:18.04"
defaultUbuntu2004ContainerDisk = "quay.io/containerdisks/ubuntu:20.04"
defaultUbuntu2204ContainerDisk = "quay.io/containerdisks/ubuntu:22.04"
Expand All @@ -51,6 +52,7 @@ var (
centosStream8ContainerDisk string
centosStream9ContainerDisk string
rhel9ContainerDisk string
rhel10ContainerDisk string
ubuntu1804ContainerDisk string
ubuntu2004ContainerDisk string
ubuntu2204ContainerDisk string
Expand Down Expand Up @@ -80,6 +82,8 @@ func init() {
defaultCentosStream9ContainerDisk, "CentOS Stream 9 container disk used by functional tests")
flag.StringVar(&rhel9ContainerDisk, "rhel-9-container-disk",
defaultRHEL9ContainerDisk, "RHEL 9 container disk used by functional tests")
flag.StringVar(&rhel10ContainerDisk, "rhel-10-container-disk",
defaultRHEL10ContainerDisk, "RHEL 10 container disk used by functional tests")
flag.StringVar(&ubuntu1804ContainerDisk, "ubuntu-1804-container-disk",
defaultUbuntu1804ContainerDisk, "Ubuntu 18.04 container disk used by functional tests")
flag.StringVar(&ubuntu2004ContainerDisk, "ubuntu-2004-container-disk",
Expand Down

0 comments on commit d1baa25

Please sign in to comment.