Fix: Correctly assign unique memory addresses for EndpointSlice ports in reconcileByAddressType #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
the
dco-signoff: no
kvaps
changed the title
kvaps
force-pushed
the
fix-duplicate-ports
branch
from
bb09519 to
9a340de
Compare
kubevirt-bot
added
dco-signoff: yes
kubevirt-bot
added
the
do-not-merge/work-in-progress
kvaps
changed the title
kvaps
force-pushed
the
fix-duplicate-ports
branch
2 times, most recently
from
4a20974 to
06f89d8
Compare
kubevirt-bot
removed
the
do-not-merge/work-in-progress
|
/assign @qinqon |
Signed-off-by: Andrei Kvapil <[email protected]>
kvaps
force-pushed
the
fix-duplicate-ports
branch
from
06f89d8 to
e26a55c
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kvaps
added a commit
to aenix-io/cozystack
that referenced
this pull request
Dec 9, 2024
Upstream fixes: - kubevirt/cloud-provider-kubevirt#335 - kubevirt/cloud-provider-kubevirt#336 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - **New Features** - Incremented Kubernetes chart version to 0.14.1. - Introduced a new cloud provider controller for managing EndpointSlices in KubeVirt, enhancing responsiveness to service changes. - **Improvements** - Updated Docker image tag for kubevirt-cloud-provider to use the latest version. - Enhanced handling of EndpointSlices for LoadBalancer services, improving service management. - **Bug Fixes** - Improved error handling and logging for service retrieval and EndpointSlice management. - **Documentation** - Updated version mappings in the versions map file for clarity and tracking. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Andrei Kvapil <[email protected]>
klinch0
approved these changes
Dec 9, 2024
|
@klinch0: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where
EndpointPortfields inreconcileByAddressTypepointed to the same memory address across iterations, causing duplicate values indesiredPorts. The fix ensures unique memory addresses are used for each port by creating separate variables forName,Protocol, andTargetPorton each loop iteration.