Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-54239: selected VMs is not getting updates #2334

Merged

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Dec 26, 2024

📝 Description

When saving the whole VM object when checking a row, it doesn't get updated when the VM is updated, but we simply have a copy of the VM object when selected which is causing the bulk actions to be incorrect after selecting VMs and doing a bulk action on them.
The fix includes changing the logic to save the VM's name and namespace identifiers, observing a mapper of VMs that gets updated on changes and apply the right actions.

🎥 Demo

Before:

bulk-actions-dont-refresh-b4.mp4

After:

bulk-actions-dont-refresh-fixed.mp4

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 26, 2024

@avivtur: This pull request references CNV-54239 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

📝 Description

When saving the whole VM object when checking a row, it doesn't get updated when the VM is updated, but we simply have a copy of the VM object when selected which is causing the bulk actions to be incorrect after selecting VMs and doing a bulk action on them.
The fix includes changing the logic to save the VM's name and namespace identifiers, observing a mapper of VMs that gets updated on changes and apply the right actions.

🎥 Demo

Before:

bulk-actions-dont-refresh-b4.mp4

After:

bulk-actions-dont-refresh-fixed.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from pcbailey and tnisan December 26, 2024 09:42
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Dec 26, 2024
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Dec 30, 2024
Copy link
Contributor

openshift-ci bot commented Dec 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9411e49 into kubevirt-ui:main Dec 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants