CNV-54208: The dropdown menu of "Actions" is not closed by clicking somewhere else #2332
Conversation
|
@avivtur: This pull request references CNV-54208 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
avivtur
force-pushed
the
action-dropdown-doesnt-close-click-outside
branch
2 times, most recently
from
3d5ed64 to
de9230f
Compare
.gitignore
Outdated
| *.json-* | ||
| .codegpt |
avivtur
force-pushed
the
action-dropdown-doesnt-close-click-outside
branch
from
de9230f to
e6ebc76
Compare
…omewhere else Signed-off-by: Aviv Turgeman <[email protected]>
avivtur
force-pushed
the
action-dropdown-doesnt-close-click-outside
branch
from
e6ebc76 to
101f9a0
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
This regression was introduced when we changed the actions dropdown to a Popper component that needs to add an effect to make this behavior happen (which comes out of the box when using Select component with onOpenChange prop).
Enhancing the useClickOutside hook that we already have for this cases to get more than one ref (the menu and the toggle components refs) to solve this issue.
🎥 Demo
Before:
actions-dropdown-doesnt-close-when-clicking-outside.mp4
After:
actions-dropdown-doesnt-close-when-clicking-outside-after.mp4