Add networking-console-plugin on start-console #2292
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
With this we'll be able to run networking-console-plugin with our
start-console.sh
script .Some changes have been required to make sure in networking-console-plugin we can do the exact same thing for kubevirt-plugin
the
--port
doesn't really work with theyarn start
command so I used the env variablePORT
but I left the flag in order to support both waysneeds openshift/networking-console-plugin#147 to work
we'll be able to run the plugin within kubevirt repo with:
yarn start-console networking-console-plugin
or
yarn start-console-with-networking
🎥 Demo