Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add networking-console-plugin on start-console #2292

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented Nov 29, 2024

📝 Description

With this we'll be able to run networking-console-plugin with our start-console.sh script .

Some changes have been required to make sure in networking-console-plugin we can do the exact same thing for kubevirt-plugin

the --port doesn't really work with the yarn start command so I used the env variable PORT but I left the flag in order to support both ways

needs openshift/networking-console-plugin#147 to work

we'll be able to run the plugin within kubevirt repo with:
yarn start-console networking-console-plugin

or

yarn start-console-with-networking

🎥 Demo

Screenshot 2024-11-29 at 18 22 59

@avivtur
Copy link
Member

avivtur commented Dec 2, 2024

@upalatucci so in order for this to work, we will need to run yarn start-console only in one project right?
If there are new steps for this to work please add them to the description of the PR.
Is will still be possible to run kubevirt plugin with the networking plugin right?

@upalatucci
Copy link
Member Author

yes just like running start-console with the monitoring-plugin.
With yarn start-console networking-console-plugin

@avivtur
Copy link
Member

avivtur commented Dec 2, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Dec 2, 2024
Copy link
Contributor

openshift-ci bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e1e2178 into kubevirt-ui:main Dec 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants