-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExpandSectionWithSwitch component #1583
Add ExpandSectionWithSwitch component #1583
Conversation
940c603
to
73f255e
Compare
for me is lgtm. @hstastna |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding isIndented
prop is unnecessary, as I think all that content should have already been intended nicely and by default, without any extra prop. I mean indentation is great, I'd leave it there by default, just adding a prop to do so is unnecessary. Otherwise 👍🏽 ❇️
Just a note that according to the design changes, KSM feature won't need this component anymore.
src/utils/components/ExpandSectionWithSwitch/ExpandSectionWithSwitch.tsx
Outdated
Show resolved
Hide resolved
73f255e
to
af3ba24
Compare
I updated it to be true by default in |
af3ba24
to
4d181f0
Compare
4d181f0
to
43a7feb
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
This PR:
isIndented
andisDisabled
options to theExpandSection
componentisIndented
prop to all expandable sections on the Settings page🎥 Screenshots
ExpandSectionWithSwitch example (enabled and switch on)
ExpandSectionWithSwitch example (disabled)
Settings page before (without indents)
Settings page after (with indents)