[WIP] CNV-32374: Move template params to Catalog drawer #1564
Conversation
|
@hstastna: This pull request references CNV-32374 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hstastna: This pull request references CNV-32374 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@hstastna: This pull request references CNV-32374 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@hstastna: This pull request references CNV-32374 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hstastna
force-pushed
the
Move_template_parameters_to_the_side_drawer
branch
4 times, most recently
from
084d232 to
5e5d8c9
Compare
Move setting of the template parameters that used to be present in "Customize VirtualMachine" page one step back - to the Catalog drawer. Remove "Customize VirtualMachine" page. Fixes https://issues.redhat.com/browse/CNV-32374
hstastna
force-pushed
the
Move_template_parameters_to_the_side_drawer
branch
from
5e5d8c9 to
1910194
Compare
|
Closing this PR, as I was told the original "feature" won't be implemented, and a message to inform the user will be added instead, to solve the original problem of not being able to go back to customize template parameters while not losing any data already filled in (which is IMO possible, but...). |
📝 Description
Feature:
https://issues.redhat.com/browse/CNV-32374
Design doc:
https://docs.google.com/document/d/1IYkPyMu71UXtlvUR5C7btKSymo5E60GV_XYqCbfXLtI
Move setting of the template parameters that used to be present in "Customize VirtualMachine" page one step back - to the Catalog drawer, shorten the process of VM creation if selected template has some required parameters to be filled in. Remove "Customize VirtualMachine" page.
Note:
This is WIP PR, lots of stuff needs to be done till this will be ready to merge. Also some concerns, unanswered questions appeared, regarding the design of this feature...
🎥 Screenshots
The actual result:
