Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for release v0.18.0 #190

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Prepare for release v0.18.0 #190

merged 1 commit into from
Mar 12, 2024

Conversation

1gtm
Copy link
Contributor

@1gtm 1gtm commented Mar 12, 2024

ProductLine: KubeVault
Release: v2024.3.12
Release-tracker: kubevault/CHANGELOG#49
Signed-off-by: 1gtm [email protected]

@1gtm 1gtm added the automerge Kodiak will auto merge PRs that have this label label Mar 12, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 12, 2024
Copy link

gitguardian bot commented Mar 12, 2024

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8646284 Triggered RSA Private Key 783116d vendor/github.com/google/s2a-go/internal/v2/tlsconfigstore/testdata/server_key.pem View secret
8646284 Triggered RSA Private Key 783116d vendor/github.com/google/s2a-go/internal/v2/testdata/server_key.pem View secret
8646284 Triggered RSA Private Key 783116d vendor/github.com/google/s2a-go/internal/v2/remotesigner/testdata/server_key.pem View secret
8646284 Triggered RSA Private Key 783116d vendor/github.com/google/s2a-go/testdata/server_key.pem View secret
8646289 Triggered RSA Private Key 783116d vendor/github.com/google/s2a-go/internal/v2/testdata/client_key.pem View secret
8646289 Triggered RSA Private Key 783116d vendor/github.com/google/s2a-go/internal/v2/remotesigner/testdata/client_key.pem View secret
8646289 Triggered RSA Private Key 783116d vendor/github.com/google/s2a-go/internal/v2/tlsconfigstore/testdata/client_key.pem View secret
8646289 Triggered RSA Private Key 783116d vendor/github.com/google/s2a-go/testdata/client_key.pem View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

ProductLine: KubeVault
Release: v2024.3.12
Release-tracker: kubevault/CHANGELOG#49
Signed-off-by: 1gtm <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
@kodiakhq kodiakhq bot merged commit 0a26bfb into master Mar 12, 2024
5 checks passed
@kodiakhq kodiakhq bot deleted the v2024.3.12-master branch March 12, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Kodiak will auto merge PRs that have this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant