Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump sdk #912

Merged
merged 1 commit into from
Jun 5, 2024
Merged

bump sdk #912

merged 1 commit into from
Jun 5, 2024

Conversation

liranr23
Copy link
Member

No description provided.

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.94%. Comparing base (ee06063) to head (d74f330).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #912      +/-   ##
==========================================
- Coverage   15.94%   15.94%   -0.01%     
==========================================
  Files         106      106              
  Lines       19711    19714       +3     
==========================================
  Hits         3143     3143              
- Misses      16292    16295       +3     
  Partials      276      276              
Flag Coverage Δ
unittests 15.94% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liranr23 liranr23 marked this pull request as ready for review May 30, 2024 07:47
@ahadas
Copy link
Member

ahadas commented May 30, 2024

@liranr23 isn't it part of #713 ?

@liranr23
Copy link
Member Author

liranr23 commented Jun 2, 2024

@liranr23 isn't it part of #713 ?

i'll close #713 . #713 was a try to bump not only the sdk, but also go and the ansible operator. here it's about the operator sdk.

@liranr23 liranr23 mentioned this pull request Jun 4, 2024
Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment about OPA which doesn't seem related to this PR but let me know if I'm missing why it is related..

Makefile Outdated Show resolved Hide resolved
Signed-off-by: Liran Rotenberg <[email protected]>
Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
7.3% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liranr23 do we want this on the release-v2.6.3 branch?

@liranr23
Copy link
Member Author

liranr23 commented Jun 5, 2024

@liranr23 do we want this on the release-v2.6.3 branch?

yeah, let's backport it

@liranr23 liranr23 added this to the 2.6.3 milestone Jun 5, 2024
@ahadas ahadas merged commit 2189159 into kubev2v:main Jun 5, 2024
12 checks passed
@liranr23 liranr23 deleted the sdk branch June 5, 2024 11:13
@liranr23 liranr23 mentioned this pull request Jun 5, 2024
@ahadas ahadas removed this from the 2.6.3 milestone Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants