Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDI integration #892

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

CDI integration #892

wants to merge 4 commits into from

Conversation

bennyz
Copy link
Member

@bennyz bennyz commented May 15, 2024

With kubevirt/containerized-data-importer#3261 being merged, adjust forklift to work with the external controller, this includes, but not limited to:

  • Adjust the secret name
  • Scale down our populator controller

@bennyz
adjust secret field
db63c57 
Rename and align secret fields to secretRef to match CDI

Signed-off-by: Benny Zlotnik <[email protected]>
@bennyz bennyz force-pushed the CDI-integration branch from 32af9ff to db63c57 Compare May 15, 2024 08:50
@codecov Codecov
Copy link

codecov bot commented May 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 15.94%. Comparing base (a2170ea) to head (07b737d).
Report is 20 commits behind head on main.

❗ Current head 07b737d differs from pull request most recent head ca13b03

Please upload reports for the commit ca13b03 to get more accurate results.

Files Patch % Lines
pkg/controller/plan/adapter/ovirt/builder.go 0.00% 4 Missing ⚠️
pkg/controller/plan/adapter/openstack/builder.go 0.00% 1 Missing ⚠️
...volume-populator/populator-machinery/controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
- Coverage   17.41%   15.94%   -1.48%     
==========================================
  Files          95      106      +11     
  Lines       17005    19711    +2706     
==========================================
+ Hits         2962     3143     +181     
- Misses      13778    16292    +2514     
- Partials      265      276      +11
Flag Coverage Δ
unittests 15.94% <14.28%> (-1.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bennyz bennyz force-pushed the CDI-integration branch from 48b9b60 to 07b737d Compare May 23, 2024 14:52
bennyz added 3 commits May 28, 2024 18:42
@bennyz
Update operator and CRDs
bfc78cb 
- Scale down volume-populator-controller deployment when OCP is >= 4.16
- Update progress regex to match CDI

Signed-off-by: Benny Zlotnik <[email protected]>
@bennyz
Support CDI CRs
e0b1d66 
Signed-off-by: Benny Zlotnik <[email protected]>
@bennyz
use dynamic client to distinguish between API groups
ca13b03 
Signed-off-by: Benny Zlotnik <[email protected]>
@bennyz bennyz force-pushed the CDI-integration branch from 07b737d to ca13b03 Compare May 29, 2024 08:05
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
7.2% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnecas mnecas Awaiting requested review from mnecas mnecas will be requested when the pull request is marked ready for review mnecas is a code owner

@yaacov yaacov Awaiting requested review from yaacov yaacov will be requested when the pull request is marked ready for review yaacov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bennyz