Bump go 121 and x/net dependency (backport) #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liran Rotenberg <[email protected]>
Unfortunately, we rely on 'encoding/gob' to determine the UUID of VMs from OVAs and this package has changed in Go 1.21 in a way we get a different UUID compared to the one we get with Go 1.20 for the same input, which could break existing OVA providers. Therefore, this package integrates the relevant pieces from 'encoding/gob' of Go 1.20 so that we can bump Go to 1.21 without breaking compatibility with OVA providers that were defined in lower versions of Forklift. Signed-off-by: Arik Hadas <[email protected]>
Signed-off-by: Liran Rotenberg <[email protected]>
|
ahadas
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #880 #884 #847