Disable TPM gathering from vSphere temporarily #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addition of the property "summary.config.tpmPresent" breaks
compatibility with vSphere 6.5 ("InvalidProperty" error is returned when
building the inventory). This patch reverts this part temporarily until
we change this to work also with older versions of vSphere.
Signed-off-by: Arik Hadas <[email protected]>
|
bkhizgiy
reviewed
Jan 2, 2024
bkhizgiy
approved these changes
Jan 2, 2024
there's still enough time to fix this ;) |
liranr23
added a commit
to liranr23/forklift
that referenced
this pull request
Jan 4, 2024
Since kubev2v#694, which discovered vSphere validates the API endpoint requested, we disabled the TPM gathering to avoid "InvalidProperty" error. vSphere started supporting TPM API in 6.7, based on that version we will gather the TPM on supported versions. Signed-off-by: Liran Rotenberg <[email protected]>
liranr23
added a commit
to liranr23/forklift
that referenced
this pull request
Jan 4, 2024
Since kubev2v#694, we disabled the TPM gathering to avoid "InvalidProperty" error. vSphere started supporting TPM API in 6.7, based on that version we will gather the TPM on supported versions. Signed-off-by: Liran Rotenberg <[email protected]>
ahadas
pushed a commit
that referenced
this pull request
Jan 4, 2024
Since #694, we disabled the TPM gathering to avoid "InvalidProperty" error. vSphere started supporting TPM API in 6.7, based on that version we will gather the TPM on supported versions. Signed-off-by: Liran Rotenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of the property "summary.config.tpmPresent" breaks compatibility with vSphere 6.5 ("InvalidProperty" error is returned when building the inventory). This patch reverts this part temporarily until we change this to work also with older versions of vSphere.
Related to #665