openstack: check image is in the inventory before progressing #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyz
commented
Jan 1, 2024
| if imageID, ok := vm.Image["id"]; ok { | ||
| // Update property for image based | ||
| imageUpdateOpts := &libclient.ImageUpdateOpts{} | ||
| imageUpdateOpts.AddImageProperty(forkliftPropertyOriginalVolumeID, imageID.(string)) |
There was a problem hiding this comment.
this can break in builder.go, can't reuse the same property key
bennyz
force-pushed
the
os-image-inventory
branch
from
98ed855 to
4509a49
Compare
ahadas
reviewed
Jan 2, 2024
bennyz
force-pushed
the
os-image-inventory
branch
from
4509a49 to
557abaa
Compare
ahadas
reviewed
Jan 2, 2024
Image based migrations can get stuck since there is not check to ensure they were created in the inventory before attempting to progress, this will lead to the migration progressing to the next phase, but the PVC will not be created. This patch adds the relevant property and checks the snapshot image is in the inventory before progressing Signed-off-by: Benny Zlotnik <[email protected]>
Address review comments Signed-off-by: Benny Zlotnik <[email protected]>
bennyz
force-pushed
the
os-image-inventory
branch
from
557abaa to
c72cff3
Compare
|
ahadas
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image based migrations can get stuck since there is no check to ensure they were created in the inventory before attempting to progress, this will lead to the migration progressing to the next phase, but the PVC will not be created.
This patch adds the relevant property and checks the snapshot image is in the inventory before progressing