ovirt: Reconcile disk on USER_UPDATE_VM_DISK #646
Conversation
When a disk is extended in RHV, the size was not updated in the inventory causing the VM to be imported with old disk size. This is now solved by reconciling the disk on USER_UPDATE_VM_DISK. Signed-off-by: Nijin Ashok <[email protected]>
There was a problem hiding this comment.
thanks @nijinashok !
yeah, USER_UPDATE_VM_DISK is not handled properly - we should really handle it as a disk-property change rather than a vm-change, I think we can drop it from VMAdapter's handling
The VM-specific properties (e.g., disk interface) are handled by VMAdapter. The handling by DiskAdapter of USER_UPDATE_VM_DISK events is for updating the disk properties that are not VM-specific, this moving this event to the section of disk-events (minor change). Signed-off-by: Arik Hadas <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
after a second look, the VM-specific properties are retrieved by VMAdapter so it should still track USER_UPDATE_VM_DISK events (there's no need to change VMAdapter). I pushed a minor change with another commit that places USER_UPDATE_VM_DISK under |
When a disk is extended in RHV, the size is not updated in the inventory causing the VM to be imported with old disk size. This is now solved by reconciling the disk on USER_UPDATE_VM_DISK.
https://issues.redhat.com/browse/MTV-829