Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTV-1774 | Start all available VMs from scheduler #1263

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Dec 12, 2024

Issue:
This issue is visible with a combination of two problems. The first problem is if there is some step/phase that takes some time to finish and halts the process. An example of such an issue MTV-1775. This causes the VM migration startup to take some time as we don't start all available VMs at once but we add VMs one by one in the reconcile. This in large-scale migration can take a long time. For example on the scale of 200 VMs in best case scenario it would take 10 minutes to start all VMs as we have 3s reconciled.

Fix:
Start all available VMs from the scheduler at once.

Ref: https://issues.redhat.com/browse/MTV-1774

@mnecas mnecas requested a review from yaacov as a code owner December 12, 2024 13:09
@mnecas mnecas added this to the 2.7.7 milestone Dec 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 15.52%. Comparing base (ea38999) to head (728ca14).

Files with missing lines Patch % Lines
pkg/controller/plan/migration.go 0.00% 12 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1263      +/-   ##
==========================================
- Coverage   15.57%   15.52%   -0.06%     
==========================================
  Files         112      112              
  Lines       23255    23261       +6     
==========================================
- Hits         3623     3612      -11     
- Misses      19345    19364      +19     
+ Partials      287      285       -2     
Flag Coverage Δ
unittests 15.52% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Issue:
This issue is visible with a combination of two problems.
The first problem is if there is some step/phase that takes some time to
finish and halts the process. An example of such an issue MTV-1775.
This causes the VM migration startup to take some time as we don't start
all available VMs at once but we add VMs one by one in the reconcile.
This in large-scale migration can take a long time.
For example on the scale of 200 VMs in best case scenario it would take
10 minutes to start all VMs as we have 3s reconciled.

Fix:
Start all available VMs from the scheduler at once.

Ref: https://issues.redhat.com/browse/MTV-1774

Signed-off-by: Martin Necas <[email protected]>
Copy link

@mnecas mnecas merged commit 7c33864 into kubev2v:main Dec 12, 2024
16 checks passed
@mnecas mnecas mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants