MTV-1711 | Backport to 2.7.6, keep static IP on Debian based interfaces #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: All Debian-based operating systems can have the network configurations in the `/etc/network/interfaces`. Right now we are not fetching information from these config files when creating the udev rule to set the interface name. Fix: Add a new function to the `network_config_util.sh` script. I have decided to use the `ifquery` inside the guest. Alternatively, we would need to start parsing the config files. We can easily grep the IP address from the configfile and find the interface name but there could be multiple interface configurations inside one file. Docs: https://man.cx/interfaces(5) Signed-off-by: Martin Necas <[email protected]>
|
mnecas
approved these changes
Dec 4, 2024
yaacov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: All Debian-based operating systems can have the network configurations in the
/etc/network/interfaces. Right now we are not fetching information from these config files when creating the udev rule to set the interface name.Fix: Add a new function to the
network_config_util.shscript. I have decided to use theifqueryinside the guest.Alternatively, we would need to start parsing the config files. We can easily grep the IP address from the configfile and find the interface name but there could be multiple interface configurations inside one file.
Docs: https://man.cx/interfaces(5)