Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTV-1343 | Add pprof to the controller #1018

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Sep 6, 2024

Profiling guide:

# Forward the pods profiling port
oc port-forward -n konveyor-forklift pods/forklift-controller-5c99c54dd8-77blm 6060:6060

# Get running goroutines and heap
go tool pprof -http=:9001 localhost:6060/debug/pprof/goroutine
go tool pprof -http=:9002 localhost:6060/debug/pprof/heap

# Get trace over 5s
curl -k http://localhost:6060/debug/pprof/trace\?debug\=1\&seconds\=5 -o cpu-trace.out
go tool trace -http=:9003 ./cpu-trace.out

# List all routines
curl -k -o stage.out http://localhost:6060/debug/pprof/goroutine\?debug\=1

@mnecas mnecas requested a review from yaacov as a code owner September 6, 2024 08:16
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.43%. Comparing base (26406f2) to head (6836fc9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1018   +/-   ##
=======================================
  Coverage   16.43%   16.43%           
=======================================
  Files         107      107           
  Lines       19642    19642           
=======================================
  Hits         3229     3229           
  Misses      16126    16126           
  Partials      287      287           
Flag Coverage Δ
unittests 16.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnecas mnecas force-pushed the add_profiling branch 2 times, most recently from d6609b4 to 6836fc9 Compare September 6, 2024 10:13
@mnecas mnecas changed the title Add pprof to the controller MTV-1343 | Add pprof to the controller Sep 6, 2024
Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick, do we want to add a doc in docs/proffing-guide.md with some text, so people will know this exist and how to use it ?

Copy link

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.36%. Comparing base (f08a3a9) to head (af76bef).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1018   +/-   ##
=======================================
  Coverage   16.36%   16.36%           
=======================================
  Files         109      109           
  Lines       19628    19628           
=======================================
  Hits         3212     3212           
  Misses      16135    16135           
  Partials      281      281           
Flag Coverage Δ
unittests 16.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnecas mnecas merged commit faebb7b into kubev2v:main Sep 16, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants