MTV-1377 | Fix the auth to return 401 instead of 403 #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: When we request the inventory web endpoint the auth functions allows the user to get the endpoint even with incorrect token. Fix: Change the permit function logic so we do not set the auth=true. Signed-off-by: Martin Necas <[email protected]>
mnecas
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1013 +/- ##
==========================================
- Coverage 16.44% 16.43% -0.01%
==========================================
Files 107 107
Lines 19648 19642 -6
==========================================
- Hits 3231 3229 -2
+ Misses 16130 16126 -4
Partials 287 287
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Issue: Right now the reuqest with invalid token return 403 instead of the expected 401. Fix: Change the `permit` function to return the status code instead of boolean. Signed-off-by: Martin Necas <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First issue
Issue: When we request the inventory web endpoint the auth functions
allows the user to get the endpoint even with the incorrect token.
Fix: Change the permit function logic so we do not set the auth=true.
Second issue
Issue: Right now the request with an invalid token returns 403 instead of
the expected 401.
Fix: Change the
permitfunction to return the status code instead ofBoolean.