Add a custom CPU warning

The validation will now check if the VM is set with custom CPU model and show it to the user. Signed-off-by: Liran Rotenberg <[email protected]>
kubev2v · Dec 21, 2023 · bd4778a · bd4778a
1 parent 6667576
commit bd4778a
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/validation/policies/io/konveyor/forklift/ovirt/cpu_custom_model.rego b/validation/policies/io/konveyor/forklift/ovirt/cpu_custom_model.rego
@@ -0,0 +1,16 @@
+package io.konveyor.forklift.ovirt
+
+default no_custom_cpu_model = false
+
+no_custom_cpu_model = true {
+    count(input.customCpuModel) != 0
+}
+
+concerns[flag] {
+    no_custom_cpu_model
+    flag := {
+        "category": "Warning",
+        "label": "Custom CPU Model detected",
+        "assessment": "A custom CPU model is set on the VM. The CPU model of the VM might differ from your target cluster CPU."
+    }
+}
diff --git a/validation/policies/io/konveyor/forklift/ovirt/cpu_custom_model_test.rego b/validation/policies/io/konveyor/forklift/ovirt/cpu_custom_model_test.rego
@@ -0,0 +1,15 @@
+package io.konveyor.forklift.ovirt
+
+test_without_customcpu {
+    mock_vm := { "name": "test" }
+    results = concerns with input as mock_vm
+    count(results) == 0
+}
+
+test_with_customcpu {
+    mock_vm := { "name": "test",
+                 "customCpuModel": "Icelake-Server-noTSX,-mpx"
+                }
+    results = concerns with input as mock_vm
+    count(results) == 1
+}