Make Guest information on vNICs is missing, cannot preserve static IP…

…s a warning instead of critical error Signed-off-by: yzamir <[email protected]>
kubev2v · Dec 2, 2024 · 7d53bae · 7d53bae
1 parent 4890e07
commit 7d53bae
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/pkg/controller/plan/controller.go b/pkg/controller/plan/controller.go
@@ -326,6 +326,13 @@ func (r *Reconciler) execute(plan *api.Plan) (reQ time.Duration, err error) {
 	conditionRequiresReQ := plan.Status.HasReQCondition()
 	if plan.Status.HasBlockerCondition() || plan.Status.HasCondition(Archived) || conditionRequiresReQ {
 		if conditionRequiresReQ {
+			r.Log.Info(
+				"Found a condition requiring re-reconcile.",
+				"plan",
+				path.Join(
+					plan.GetNamespace(),
+					plan.GetName()))
+
 			reQ = base.SlowReQ
 		}
 		return

diff --git a/pkg/controller/plan/validation.go b/pkg/controller/plan/validation.go
@@ -440,8 +440,8 @@ func (r *Reconciler) validateVM(plan *api.Plan) error {
 		Type:     VMMissingGuestIPs,
 		Status:   True,
 		Reason:   MissingGuestInfo,
-		Category: Critical,
-		Message:  "Guest information on vNICs is missing, cannot preserve static IPs. Make sure VMware tools are installed and the VM is running.",
+		Category: Warn,
+		Message:  "Guest information on vNICs is missing, cannot preserve static IPs. If this machine has static IP, make sure VMware tools are installed and the VM is running.",
 		Items:    []string{},
 	}
 	missingCbtForWarm := libcnd.Condition{

diff --git a/pkg/lib/condition/condition.go b/pkg/lib/condition/condition.go
@@ -321,7 +321,7 @@ func (r *Conditions) HasBlockerCondition() bool {
 
 // The collection contains blocker conditions that keep the plan reconciling.
 func (r *Conditions) HasReQCondition() bool {
-	return r.HasCondition(ValidatingVDDK) || r.HasCondition(VMMissingGuestIPs) || r.HasCondition(VMMissingChangedBlockTracking)
+	return r.HasCondition(ValidatingVDDK) || r.HasCondition(VMMissingChangedBlockTracking)
 }
 
 // The collection contains the `Ready` condition.