Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧼 Better header page sanity #937

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Feb 21, 2024

sanity check before getGroupVersionKindForResource should test for kind in data, and not just data

Signed-off-by: Yaacov Zamir <[email protected]>
@yaacov yaacov added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 21, 2024
@yaacov yaacov added this to the 2.6.0 milestone Feb 21, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yaacov yaacov merged commit 1bbe694 into kubev2v:main Feb 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant