🧼 Fix more help text fields, based on doc team review for the OpenStack provider #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… provider Reference: kubev2v#646 Reference: kubev2v#861 (comment) Fix all comments mentioned by the doc team in kubev2v#861 and applied it to all relevant providers. Signed-off-by: Sharon Gratch <[email protected]>
|
yaacov
changed the title
yaacov
added
the
kind/cleanup
RichardHoch
reviewed
Feb 4, 2024
| <br /> | ||
| Insecure migration means that the transferred data is sent over an insecure connection | ||
| and potentially sensitive data could be exposed. | ||
| Note: If this field is checked/true, migrations from this provider will not be secure, |
There was a problem hiding this comment.
"selected" instead of "checked/true"
RichardHoch
reviewed
Feb 4, 2024
| <br /> | ||
| Insecure migration means that the transferred data is sent over an insecure connection | ||
| and potentially sensitive data could be exposed. | ||
| Note: If this field is checked/true, migrations from this provider will not be secure, |
There was a problem hiding this comment.
"selected" instead of "checked/true"
RichardHoch
reviewed
Feb 4, 2024
| <br /> | ||
| Insecure migration means that the transferred data is sent over an insecure connection | ||
| and potentially sensitive data could be exposed. | ||
| Note: If this field is checked/true, migrations from this provider will not be secure, |
There was a problem hiding this comment.
"selected" instead of "checked/true"
RichardHoch
reviewed
Feb 4, 2024
| <br /> | ||
| Insecure migration means that the transferred data is sent over an insecure connection | ||
| and potentially sensitive data could be exposed. | ||
| Note: If this field is checked/true, migrations from this provider will not be secure, |
There was a problem hiding this comment.
"selected" instead of "checked/true"
RichardHoch
reviewed
Feb 4, 2024
| <br /> | ||
| Insecure migration means that the transferred data is sent over an insecure connection | ||
| and potentially sensitive data could be exposed. | ||
| Note: If this field is checked/true, migrations from this provider will not be secure, |
There was a problem hiding this comment.
"selected" instead of "checked/true"
RichardHoch
reviewed
Feb 4, 2024
| <br /> | ||
| Insecure migration means that the transferred data is sent over an insecure connection and | ||
| potentially sensitive data could be exposed. | ||
| Note: If this field is checked/true, migrations from this provider will not be secure, |
There was a problem hiding this comment.
"selected" instead of "checked/true"
|
Great work, @sgratch! There's one small repeated error which I may have missed before. Otherwise, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #646
Reference: #861 (comment)
Fix all comments mentioned by the doc team in PR #861 and applied it to all relevant providers if relevant.