Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐾 Add a fast Create Plan page - step 2 #834

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

rszwajko
Copy link
Contributor

@rszwajko rszwajko commented Jan 18, 2024

Implements #801

Screenshot from 2024-01-19 17-59-44
Screenshot from 2024-01-19 18-00-05
image

@rszwajko rszwajko requested review from sgratch and yaacov January 18, 2024 15:10
@yaacov yaacov changed the title Add a fast Create Plan page - step 2 🐾 Add a fast Create Plan page - step 2 Jan 18, 2024
@yaacov yaacov added the enhancement Categorizes issue or PR as related to a new feature. label Jan 18, 2024
@yaacov yaacov added this to the 2.6.0 milestone Jan 18, 2024
@rszwajko rszwajko marked this pull request as ready for review January 19, 2024 14:58
@rszwajko rszwajko marked this pull request as draft January 19, 2024 15:09
Changes:
1. plan name validation - name is unique
2. display selected VMs in a side panel (drawer) as a table
   (StandardPage component with all available features)
3. provide custom EditableDescriptionItem component to handle cases when
   editable content is already a link.
4. add support for targetProvider and targetNamespace
5. hook for loading available target namespaces from the inventory

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rszwajko rszwajko marked this pull request as ready for review January 19, 2024 17:27
@yaacov yaacov merged commit 46a1b0c into kubev2v:main Jan 22, 2024
7 checks passed
@yaacov yaacov added the plans label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Categorizes issue or PR as related to a new feature. plans
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants