-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐾 Add a fast Create Plan page - step 1 #822
Conversation
nice 👍 added comment in #801 (comment) for separation of #801 into steps |
@rszwajko , can you update the title and description to indicate this is a PR for the first step, "Add fast migration page" may indicate this PR actually adds the complete fast migration form ? |
packages/forklift-console-plugin/src/modules/Providers/dynamic-plugin.ts
Show resolved
Hide resolved
...ift-console-plugin/src/modules/Providers/views/migrate/ProvidersCreateVmMigrationContext.tsx
Outdated
Show resolved
Hide resolved
...rklift-console-plugin/src/modules/Providers/views/migrate/ProvidersCreateVmMigrationPage.tsx
Show resolved
Hide resolved
...rklift-console-plugin/src/modules/Providers/views/migrate/ProvidersCreateVmMigrationPage.tsx
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/modules/Providers/views/migrate/index.ts
Show resolved
Hide resolved
packages/forklift-console-plugin/src/modules/Providers/views/migrate/reducer.ts
Show resolved
Hide resolved
fca5a15
to
5d22ebb
Compare
@yaacov
Parts not implemented (yet):
|
inmplementing the "create and edit" button is the last step, no need to do it now
yes, it's "create" the plan is valid and created, "and edit" you go to the details/edit page
why will you want to change the target, that is not part of the spec |
that is why it need to be a "lateral" flow, a user will not open the vm list unless they need what to check somthing, "lateral" is somthing outside the regular flow - e.g. a modal or a side pane, the user see it check they didn't make a mistake in the last phase and continue.
they will not open the vm list unless they wnat to check somethig, but if they do want to check, they will not need to leave the create form, the quicly see the list and then close the modal or side pane
the source, and vm list are the unique featuers of this plan, you should not touch them, if you want to change them, cancel this plan and start a new one with other source and vm list |
...ugin/src/modules/Providers/views/details/tabs/VirtualMachines/components/MigrationAction.tsx
Show resolved
Hide resolved
packages/forklift-console-plugin/src/modules/Providers/views/migrate/PlansCreateForm.tsx
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/modules/Providers/views/migrate/PlansCreateForm.tsx
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/modules/Providers/views/migrate/PlansCreateForm.tsx
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/modules/Providers/views/migrate/PlansCreateForm.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things to finish
a. remove description field (not in "fast create flow")
b. show only "[N] vms selected" (we can leave the side pane with the vm list to later step)
c. remove current target provider and target namespace because they will need hooks to get them, drop down implementation, and some logic to indicate to users that once you choose them you reset the mapings.
we can move the implementation to the next step
5d22ebb
to
58cf798
Compare
Changes: 1. transfer data from VM List screen to Create Plan page via console.context-provider 2. add immer library to keep data in the reducer immutable 3. add uuid library to generate random suffixes 4. use forms for the Create Plan page - similar to Create Provider Signed-off-by: Radoslaw Szwajkowski <[email protected]>
58cf798
to
1c385d6
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
@yaacov as for the discussion above:
just to be clear the plan displayed on the screen won't be valid in all cases
It's part of the spec. You explicitly requested an editable drop down. regarding VM details representation:
OK so displaying table in the standard view is not possible. We could display it in list view (see below). The view is automatic for small spaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Implements #801
Initial state
Plan name edited