Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump css-tools for CVE-2023-26364 and CVE-2023-48631 #797

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

ahadas
Copy link
Member

@ahadas ahadas commented Dec 17, 2023

No description provided.

@ahadas ahadas requested review from yaacov and liranr23 December 17, 2023 15:12
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
7.7% Duplication on New Code

See analysis details on SonarCloud

@yaacov
Copy link
Member

yaacov commented Dec 17, 2023

package-lock.json is auto generated, the file we need to update is package.json

looking into what need to be changed there ...

@ahadas
Copy link
Member Author

ahadas commented Dec 17, 2023

@yaacov I see that it comes with @testing-library/[email protected] - does it mean that it's only used in tests?...

@yaacov
Copy link
Member

yaacov commented Dec 17, 2023

I see that it comes with @testing-library/[email protected]

looks like it, I'll try to bump the jest-dom package ...

@ahadas
Copy link
Member Author

ahadas commented Dec 17, 2023

I see that it comes with @testing-library/[email protected]

looks like it, I'll try to bump the jest-dom package ...

but the latest seems to take 4.3.1..
even though, if it's only for testing then it's not that important...

@yaacov
Copy link
Member

yaacov commented Dec 17, 2023

even though, if it's only for testing then it's not that important...

our current package-lock.jsonis out of sync, it will need some TLC, after we remove @migtools/lib-ui

so I will merge this change for GHSA-hpx4-r86g-5jrg to be happy

@yaacov yaacov merged commit 42672f8 into kubev2v:main Dec 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants