Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RowMapper optional for StandardPage #794

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

rszwajko
Copy link
Contributor

@rszwajko rszwajko commented Dec 7, 2023

Fallback to default row mapper that renders all values as string.

Motivation:

  1. for simple pages custom mapper is an overhead
  2. simplifies debugging row mapper related issues
  3. prepares ground for adding cell-level mappers (follow-up PRs)

Provider list with custom mapper

Screenshot from 2023-12-07 15-55-43

Provider list with default row mapper

Screenshot from 2023-12-07 15-56-12

Fallback to default row mapper that renders all values as string.

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rszwajko rszwajko requested review from yaacov and sgratch December 7, 2023 15:37
@yaacov yaacov merged commit 31e5d8a into kubev2v:main Jan 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants