Autocomplete filter #787
Merged
Autocomplete filter #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rszwajko
force-pushed
the
autocompleteFilter
branch
2 times, most recently
from
8669efd to
8ede558
Compare
Typeahead filter inspired by Console's AutocompleteInput. Key features: 1. match the search pattern in the entire string (not only prefix) 2. reset the filter after selection - the selected item is visible in the chip list Contract: 1. enum values passed as supportedValues param have id prop the same as the label prop 2. values in supportedValues are unique (no de-duplication similar to EnumFilter) Reference-Url: http://v4-archive.patternfly.org/v4/components/select#typeahead Reference-Url: https://github.com/openshift/console/blob/cf961054415464ba90959b614517903fc9b808a3/frontend/public/components/autocomplete.tsx#L22 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
rszwajko
force-pushed
the
autocompleteFilter
branch
from
8ede558 to
2fd64e4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Fixes: #790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typeahead filter inspired by Console's AutocompleteInput.
Key features:
the chip list
Contract:
the label prop
to EnumFilter)
Reference-Url: http://v4-archive.patternfly.org/v4/components/select#typeahead
Reference-Url: https://github.com/openshift/console/blob/cf961054415464ba90959b614517903fc9b808a3/frontend/public/components/autocomplete.tsx#L22
Screencast.from.2023-11-27.13-17-46.webm