Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add second info ExternalLink field to the DetailsItem component #780

Closed
wants to merge 1 commit into from
Closed

Add second info ExternalLink field to the DetailsItem component #780

wants to merge 1 commit into from

Conversation

sgratch
Copy link
Collaborator

@sgratch sgratch commented Nov 12, 2023 •
edited
Loading

Add a second ExternalLink field as another info link to the DetailsItem component.
This will be used for cases in which there are two external links as an additional info. E.g, for the OpenShift URL field there are two doc references.

screenshot

image

@sgratch
Add second info ExternalLink field to the DetailsItem component
e0d78bd 
Add a second ExternalLink field as another info link to the DetailsItem
component.
This will be used for cases in which there are two external links as an
additional info. E.g, for the OpenShift URL field there are two doc
references.

Signed-off-by: Sharon Gratch <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@sgratch sgratch requested review from yaacov and rszwajko November 12, 2023 20:12
@yaacov
Copy link
Member

yaacov commented Nov 13, 2023

@sgratch hi, can you be more specific about two documentation links for the same topic ? can it bw a documentation bug, same topic twice in the docs ?

@sgratch
Copy link
Collaborator Author

sgratch commented Nov 13, 2023

@sgratch hi, can you be more specific about two documentation links for the same topic ? can it bw a documentation bug, same topic twice in the docs ?

@yaacov there is one case that currently requires that, as mentioned in the description of this PR, for the OpenShift provider's URL doc reference (see the screenshot). There are two separate doc sections for OpenShift and we need to reference both somehow:
Adding OCP as a source
Adding OCP as a destination
Anyway, if you don't like this fix and prefer a better enhancement like adding titles for the references, then let's postpone this fix for later.
I'll close this fix for now and open an issue for future handling

@sgratch sgratch closed this Nov 13, 2023
@sgratch sgratch mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaacov yaacov Awaiting requested review from yaacov

@rszwajko rszwajko Awaiting requested review from rszwajko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgratch @yaacov