-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Edit URL modal text for the oVirt provider #773
Conversation
cc:// @RichardHoch @anarnold97 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need rebase
@sgratch @yaacov @anarnold97 @ahadas Do I need to change the description in the documentation? |
@sgratch hi, please notice #773 (comment) |
826a723
to
c2ca59d
Compare
@RichardHoch just final check before merging :-) |
Fix the Edit URL modal text for the oVirt provider, based on the create provider help texts: 1. Rephrase the title and help text field 2. Support warning text message and icon Signed-off-by: Sharon Gratch <[email protected]>
c2ca59d
to
fdb1180
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Current text In Doc: Current text In UI: |
@sgratch It took some to time to arrive at the documentation text. The UI text looks close enough to me, except it needs to end in a period, not a comma. |
Reference: #646
Fix the Edit URL modal text for the oVirt provider, based on the create provider help texts:
Before the fix
After the fix