Filter by all concerns present in the VM #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rszwajko
changed the title
rszwajko
force-pushed
the
filterByAllConcerns
branch
from
5a66153 to
30d66d6
Compare
yaacov
reviewed
Sep 28, 2023
...e-plugin/src/modules/Providers/views/details/tabs/VirtualMachines/OvaVirtualMachinesList.tsx
Outdated
Show resolved
Hide resolved
rszwajko
force-pushed
the
filterByAllConcerns
branch
2 times, most recently
from
32ceecd to
1111a55
Compare
|
@rszwajko hi, can you clean up the commits ? |
Before only the most severe concern was used for filtering. Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
rszwajko
force-pushed
the
filterByAllConcerns
branch
from
bf2b48a to
87ff4ad
Compare
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #720
Before this PR only the most severe concern was used for filtering i.e. filtering by category
Informationwas not possible if the VM had a more sever concern.Screencast.from.09-28-2023.07.41.09.PM.webm