Reading the cacert field value as undefined in case it's empty #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: https://issues.redhat.com/browse/MTV-1653 Fix a bug in which in case of an empty/undefined cacert field value, read it as undefined and not as 'undefined' (the result of (string(undefined) expr) Signed-off-by: Sharon Gratch <[email protected]>
|
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1424 +/- ##
==========================================
- Coverage 36.81% 36.20% -0.62%
==========================================
Files 158 159 +1
Lines 2548 2580 +32
Branches 599 602 +3
==========================================
- Hits 938 934 -4
- Misses 1428 1631 +203
+ Partials 182 15 -167 ☔ View full report in Codecov by Sentry. |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://issues.redhat.com/browse/MTV-1653
Fix a bug in which in case of an empty/undefined cacert field value, read it as
undefinedand not as'undefined'(the result of (string(undefined) expr).This fixes the verification if the cacert field is empty or not.
Screencast to show that this will fix bug https://issues.redhat.com/browse/MTV-1653
Screencast.from.2024-12-30.20-07-14.webm