Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MTV-1786] Add tooltip to Create plan wizard's Target namespace field #1410

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Dec 13, 2024

https://issues.redhat.com/browse/MTV-1786

Summary

  • Added tooltip with text shared in this design JIRA:
    https://issues.redhat.com/browse/HPUX-228
  • Added common component for help icons with popovers. Can make a separate task to convert several repeated instances of using the same help icon popover soon if this is acceptable.
image

@jpuzz0 jpuzz0 force-pushed the MTV-1786-target-namespace-tooltip branch from 54fbc4e to f5e85a0 Compare December 13, 2024 01:12
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.21%. Comparing base (13484d0) to head (f5e85a0).
Report is 152 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1410      +/-   ##
==========================================
- Coverage   36.81%   36.21%   -0.60%     
==========================================
  Files         158      159       +1     
  Lines        2548     2579      +31     
  Branches      599      601       +2     
==========================================
- Hits          938      934       -4     
- Misses       1428     1630     +202     
+ Partials      182       15     -167     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@yaacov yaacov merged commit a1408ed into kubev2v:main Dec 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants