Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editing plan settings only for specific plan's statuses #1393

Merged

Conversation

sgratch
Copy link
Collaborator

@sgratch sgratch commented Nov 27, 2024

Reference: https://issues.redhat.com/browse/MTV-1713

Enable editing of plan details -> settings fields only for the following plan statuses:
'Unknown', 'Canceled', 'Error', 'Failed', 'vmError', 'Warning', 'Ready '
and disable the edit option for those settings fields for all other plan statuses.

Screenshot example for an archived plan

Before

Screenshot from 2024-11-27 15-28-31

After

Screenshot from 2024-11-27 15-27-33

Reference: https://issues.redhat.com/browse/MTV-1713

Enable editing of plan details -> settings fields only for the following
plan statuses:
Unknown', 'Canceled', 'Error', 'Failed', 'vmError', 'Warning', 'Ready
and disable the edit option for all others.

Signed-off-by: Sharon Gratch <[email protected]>
@sgratch sgratch requested a review from yaacov November 27, 2024 13:29
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.16%. Comparing base (13484d0) to head (40e7bb5).
Report is 130 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1393      +/-   ##
==========================================
- Coverage   36.81%   36.16%   -0.65%     
==========================================
  Files         158      158              
  Lines        2548     2577      +29     
  Branches      599      615      +16     
==========================================
- Hits          938      932       -6     
- Misses       1428     1450      +22     
- Partials      182      195      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yaacov yaacov merged commit 0047638 into kubev2v:main Nov 27, 2024
10 checks passed
@sgratch sgratch deleted the plan-settings-editing-based-on-plan-status branch November 27, 2024 14:02
@sgratch sgratch added the bug Categorizes issue or PR as related to a bug. label Nov 27, 2024
@sgratch sgratch modified the milestones: 2.8.0, 2.7.6 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants