Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --arch when running podman to allow running on ARM machines #1380

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Nov 5, 2024

As suggested by @jschuler add a --arch=amd64 flag to allow running the console pod using podman on an ARM machine, such as macos

@yaacov
Copy link
Member Author

yaacov commented Nov 5, 2024

cc:// @sgratch @jschuler

Copy link

sonarqubecloud bot commented Nov 5, 2024

@yaacov yaacov added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 5, 2024
@yaacov yaacov added this to the 2.8.0 milestone Nov 5, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.16%. Comparing base (13484d0) to head (7e9b367).
Report is 114 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1380      +/-   ##
==========================================
- Coverage   36.81%   36.16%   -0.65%     
==========================================
  Files         158      158              
  Lines        2548     2577      +29     
  Branches      599      601       +2     
==========================================
- Hits          938      932       -6     
- Misses       1428     1630     +202     
+ Partials      182       15     -167     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jschuler
Copy link
Contributor

jschuler commented Nov 5, 2024

LGTM! Thanks @yaacov

@yaacov yaacov merged commit 82a85d1 into kubev2v:main Nov 5, 2024
10 checks passed
@sgratch sgratch modified the milestones: 2.8.0, 2.7.6 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants