[v2.7.3] Update hasObjectChangedInGivenFields to ignore predefined fields #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: https://issues.redhat.com/browse/MTV-1546 - Check if the inventory data has changed for re-loading the data to UI and re-rendering only for specified fields by ignoring a pre-defined list of fields. - Remove unused hasObjectChangedInGivenFields duplicate method implementation. Up till now, all fields have been compared to check if something was changed for reloading. But since there are few fields that are changed occasionally in inventory, while not being displayed in UI, we can ignore them while checking for new data, for less requent unnecessary re-rendering. Signed-off-by: Sharon Gratch <[email protected]>
|
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release-2.7 #1366 +/- ##
==============================================
Coverage ? 36.46%
==============================================
Files ? 159
Lines ? 2589
Branches ? 616
==============================================
Hits ? 944
Misses ? 1450
Partials ? 195 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://issues.redhat.com/browse/MTV-1546
Up till now, all fields have been compared to check if something was changed for reloading. But since there are few fields that are changed occasionally in inventory, while not being displayed in UI, we can ignore them while checking for new data, for less requent unnecessary re-rendering.