Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐾 Update to PF5 - part III #1336

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Sep 24, 2024

Ref: #1099

Move rest of the code to PF5 elements, use depracted components where needed.

  • Replacing npm with yarn - as workaround to webpack specific version issue ( CON-14300 )
    • Replacing docs to use yarn
    • Replacing package.json scripts to use yarn
    • Replacing automation to use yarn
    • Adding concurrency to enable live reload on common package sorce changes
  • Update react libraries to "17.0.2" to match console version
    • add missing children prop to React.FC
  • Update plugin libraries to "1.6.0" to match console version
    • Update @openshift-console/dynamic-plugin-sdk-webpack
  • Update Patternfly from "PF4" to "PF5"
    • Dropdown - using deprecated component variant
    • Select - using deprecated component variant
    • EmptyState - using new version
    • Table - using new version
    • Card - using new version
    • Alert - using new version
    • onToggle - update usage
    • onChange - update usage

@yaacov yaacov added the enhancement Categorizes issue or PR as related to a new feature. label Sep 24, 2024
@yaacov yaacov added this to the 2.8.0 milestone Sep 24, 2024
@yaacov yaacov force-pushed the pf5-init-conversion branch 24 times, most recently from 4f6d8f8 to 08c64da Compare September 27, 2024 18:34
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 58.33333% with 15 lines in your changes missing coverage. Please review.

Project coverage is 36.20%. Comparing base (13484d0) to head (17efe7f).
Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
packages/common/src/components/Page/PageStates.tsx 50.00% 3 Missing ⚠️
...viders/utils/components/Gallery/SelectableCard.tsx 25.00% 3 Missing ⚠️
...ommon/src/components/Filter/AutocompleteFilter.tsx 50.00% 1 Missing ⚠️
...ckages/common/src/components/Filter/EnumFilter.tsx 50.00% 1 Missing ⚠️
...common/src/components/Filter/GroupedEnumFilter.tsx 50.00% 1 Missing ⚠️
...ages/common/src/components/Filter/SwitchFilter.tsx 0.00% 1 Missing ⚠️
...rc/components/FilterGroup/AttributeValueFilter.tsx 50.00% 1 Missing ⚠️
...c/modules/Providers/modals/EditModal/EditModal.tsx 0.00% 1 Missing ⚠️
...ls/EditProviderVDDKImage/EditProviderVDDKImage.tsx 0.00% 1 Missing ⚠️
...components/CertificateUpload/CertificateUpload.tsx 0.00% 1 Missing ⚠️
... and 1 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1336      +/-   ##
==========================================
- Coverage   36.81%   36.20%   -0.61%     
==========================================
  Files         158      158              
  Lines        2548     2574      +26     
  Branches      599      602       +3     
==========================================
- Hits          938      932       -6     
- Misses       1428     1460      +32     
  Partials      182      182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yaacov yaacov marked this pull request as ready for review September 27, 2024 18:42
@yaacov yaacov force-pushed the pf5-init-conversion branch from 64c7624 to 08c64da Compare September 27, 2024 19:01
@yaacov
Copy link
Member Author

yaacov commented Sep 29, 2024

cc:// @mnecas hi, we are changing the build from npm to yarn this may require changes downstream,
in upstream we are changing the dockerfile to use yarn
https://github.com/kubev2v/forklift-console-plugin/pull/1336/files#diff-a3f0be6dea3e9b0a008fc2a7168f9b03207992d7179cb226135a3948837bdee1

- RUN npm ci && npm run build
+ RUN command -v yarn || npm i -g yarn
+ RUN yarn install --frozen-lockfile --ignore-engines && yarn build

Signed-off-by: yaacov <[email protected]>
@yaacov yaacov force-pushed the pf5-init-conversion branch from 08c64da to 17efe7f Compare October 1, 2024 08:36
Copy link

sonarqubecloud bot commented Oct 1, 2024

@yaacov yaacov merged commit 96074b8 into kubev2v:main Oct 1, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants